FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Refactoring form element. · Pull Request #89 · doctrine/DoctrineModule · GitHub

  1. doctrine
  2. DoctrineModule

Repository navigation

Refactoring form element. - #89

Merged
Ocramius merged 3 commits into
masterfrom
unknown repository
Oct 16, 2012
ConversationCommits (3)ChecksFiles changed
Merged

Refactoring form element.#89
Ocramius merged 3 commits into
masterfrom
unknown repository

Conversation

ghost commented Sep 25, 2012

Copy link
Copy Markdown

No description provided.

ghost mentioned this pull request Sep 25, 2012
Merged

ghost commented Sep 25, 2012

Copy link
Copy Markdown
Author

Goes with doctrine/DoctrineORMModule#128

Ocramius commented Sep 30, 2012

Copy link
Copy Markdown
Member

I'm late on this... Didn't really understand what the proxy is for... What's the idea behind it? Having identifier arrays and instead showing entities to the end user?

bakura10 reviewed Oct 1, 2012
View reviewed changes
Comment thread src/DoctrineModule/Form/Element/Proxy.php

bakura10 Oct 1, 2012

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Add docblock.

bakura10 commented Oct 1, 2012

Copy link
Copy Markdown
Member

@Ocramius except the lack of tests, it looks good to merge !

ghost commented Oct 2, 2012

Copy link
Copy Markdown
Author

The reason for the proxy is so that we don't have to duplicate the query code.

bakura10 commented Oct 15, 2012

Copy link
Copy Markdown
Member

Any news @spiffyjr ?

ghost commented Oct 16, 2012

Copy link
Copy Markdown
Author

Me being super busy with work and the kid is all. The little time I do have I've been spending on a side project. I'll try and write tests as soon as I can.

ghost commented Oct 16, 2012

Copy link
Copy Markdown
Author

Hooray for tests! Merge me, kthx.

Ocramius commented Oct 16, 2012

Copy link
Copy Markdown
Member

\o/ willmerge once at home \o/

No problem about times, I understand your priority :)

bakura10 commented Oct 16, 2012

Copy link
Copy Markdown
Member

Yeah that's cool, thanks Spiffy.

Ready for some code refactoring \o/ !

Ocramius added a commit that referenced this pull request Oct 16, 2012
Merge pull request #89 from SpiffyJr/feature/form-element-refactor
177fee6 
Refactoring form element.
Ocramius merged commit 177fee6 into doctrine:master Oct 16, 2012
gencer pushed a commit to gencer/DoctrineModule that referenced this pull request Apr 11, 2014
Merge pull request doctrine#89 from liuggio/patch-3
bd1d3da 
fixed doctrine#88 deprecated help information
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

RFC

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL