FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

update torchsharp to 0.105.0 by LittleLittleCloud · Pull Request #7416 · dotnet/machinelearning · GitHub

/ machinelearning Public

update torchsharp to 0.105.0 - #7416

Closed
LittleLittleCloud wants to merge 1 commit into
mainfrom
u/xiaoyun/updateTorchsharp
ConversationCommits (1)ChecksFiles changed
Closed

update torchsharp to 0.105.0#7416
LittleLittleCloud wants to merge 1 commit into
mainfrom
u/xiaoyun/updateTorchsharp

Conversation

LittleLittleCloud commented Mar 12, 2025

Copy link
Copy Markdown
Member

We are excited to review your PR.

So we can do the best job, please check:

  • There's a descriptive title that will make sense to other developers some time from now.
  • There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
  • Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
  • You have included any necessary tests in the same PR.

Copilot AI review requested due to automatic review settings March 12, 2025 00:12
Copilot AI reviewed Mar 12, 2025
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Pull Request Overview

This PR updates the TorchSharp integration to version 0.105.0 by refining API calls and enforcing non-null assertions on buffers. Key changes include:

  • Adding null-forgiving operators ("!") to get_buffer calls in both RotaryEmbedding.cs and QuantizedLinear.cs.
  • Updating named parameter "kernelSize" to "kernel_size" in ConvModule.cs to align with TorchSharp’s API.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
src/Microsoft.ML.GenAI.Core/Module/RotaryEmbedding.cs Added null-forgiving operator on get_buffer usage.
src/Microsoft.ML.GenAI.Core/Module/QuantizedLinear.cs Added null-forgiving operator on multiple get_buffer calls and adjusted arithmetic operations.
src/Microsoft.ML.TorchSharp/AutoFormerV2/ConvModule.cs Renamed named parameter for consistency with TorchSharp.

ericstj commented Mar 12, 2025

Copy link
Copy Markdown
Member

Which feed are these new versions published to? If only nuget.org, should they be mirrored?

michaelgsharp commented Mar 31, 2025

Copy link
Copy Markdown
Contributor

Yes it needs mirroring. Being done here, https://dev.azure.com/dnceng/internal/_build/results?buildId=2676108&view=results.

michaelgsharp commented Mar 31, 2025

Copy link
Copy Markdown
Contributor

/azp run

azure-pipelines Bot commented Mar 31, 2025

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

michaelgsharp commented Mar 31, 2025

Copy link
Copy Markdown
Contributor

Ah, I think I remember now. The reason we had stayed on the old version was that these newer versions don't support OSX-x64. So its gonna require a bit more work to swap versions @LittleLittleCloud. Going to have to stop torch sharp from building on osx x64 and skip those tests there as well. We've dont something similar in ML.NET for x86, but now it will need to be expanded to this as well.

build-analysis Bot mentioned this pull request Apr 1, 2025
Open
This was referenced Mar 4, 2026
Open
Closed
github-actions Bot mentioned this pull request May 29, 2026
Closed
This was referenced Jun 15, 2026
Closed
Closed

rosebyte commented Sep 9, 2026

Copy link
Copy Markdown
Member

closing as stale, the current torchsharp version is 0.107.0 anyway

rosebyte closed this Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees

LittleLittleCloud

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL