Use direct URLs for test resources - #7663
Merged
ericstj merged 4 commits intoJul 22, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Temporarily bypass deleted aka.ms aliases for test datasets and centralize resilient direct downloads in the shared test framework. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 57cca22a-bb40-4b25-b169-1c9e46ae88e1
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates ML.NET test infrastructure to bypass broken/deleted aka.ms/mlnet-resources aliases by switching tests/benchmarks to direct public URLs, and centralizes downloading logic into a shared helper to improve reliability.
Changes:
- Added TestDownloadUtils to perform bounded, retrying downloads via a temp-file + atomic move pattern.
- Updated TensorFlow and AutoML test datasets to download from direct mlpublicassets blob URLs.
- Updated performance benchmarks to fetch datasets from either raw GitHub (repo test/data) or mlpublicassets benchmark blobs.
| File | Description |
|---|---|
| test/Microsoft.ML.TestFrameworkCommon/TestDownloadUtils.cs | New shared download helper with retry + temp-file move semantics. |
| test/Microsoft.ML.TestFrameworkCommon/Microsoft.ML.TestFrameworkCommon.csproj | Enables nullable annotations and links in RetryHelper for retries. |
| test/Microsoft.ML.TensorFlow.Tests/TensorflowTests.cs | Replaces ResourceManagerUtils downloads with direct blob URLs + TestDownloadUtils. |
| test/Microsoft.ML.PerformanceTests/ImageClassificationBench.cs | Switches dataset URL from aka.ms to direct blob URL. |
| test/Microsoft.ML.PerformanceTests/BenchmarkBase.cs | Replaces resource manager downloads with direct URL downloads via TestDownloadUtils. |
| test/Microsoft.ML.AutoML.Tests/DatasetUtil.cs | Switches dataset URL from aka.ms to direct blob URL. |
Copilot's findings
- Files reviewed: 6/6 changed files
- Comments generated: 2
Sorry, something went wrong.
Comment thread
test/Microsoft.ML.TestFrameworkCommon/TestDownloadUtils.cs
Comment thread
test/Microsoft.ML.PerformanceTests/BenchmarkBase.cs
Outdated
Validate response content length and remove the unused benchmark path local. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 57cca22a-bb40-4b25-b169-1c9e46ae88e1
ericstj
enabled auto-merge (squash)
July 16, 2026 21:11
auto-merge was automatically disabled
July 17, 2026 02:03
Pull request was closed
matouskozak
approved these changes
Jul 17, 2026
matouskozak
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks a lot for fixing this
Sorry, something went wrong.
Comment thread
test/Microsoft.ML.PerformanceTests/BenchmarkBase.cs
Outdated
tarekgh
reviewed
Jul 17, 2026
Comment thread
test/Microsoft.ML.TestFrameworkCommon/TestDownloadUtils.cs
Outdated
Use a local-only helper for checked-in benchmark data and reserve network downloads for explicit external datasets. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 57cca22a-bb40-4b25-b169-1c9e46ae88e1
tarekgh
approved these changes
Jul 17, 2026
Handle OperationCanceledException from timed-out response body copies in addition to TaskCanceledException. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 57cca22a-bb40-4b25-b169-1c9e46ae88e1
ericstj
enabled auto-merge (squash)
July 17, 2026 16:16
Copy link
Copy Markdown
Member
Sorry, something went wrong.
tarekgh
approved these changes
Jul 21, 2026
Copy link
Copy Markdown
Member
Author
|
Yeah, but I can't merge it. Let me try the override to see if it works here. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
Assignees
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #7662
Validation