Add LoadFromDatabase convenience methods (#4182) - #7666
Open
rAJt-11 wants to merge 2 commits into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Add LoadFromDatabase<TInput> extension methods on DataOperationsCatalog that combine CreateDatabaseLoader<TInput>() and Load(DatabaseSource) into a single call, mirroring the existing LoadFromTextFile<TInput> sugar.
Copy link
Copy Markdown
Author
|
@dotnet-policy-service agree |
Sorry, something went wrong.
This was referenced Jul 24, 2026
Closed
Replace the redundant LightGBM training test with a focused, self-contained in-memory SQLite test that verifies LoadFromDatabase loads the expected data through both the DatabaseSource and DbProviderFactory overloads. This scopes the test to the new data-loading API and avoids adding a training run to the test suite.
Copy link
Copy Markdown
Author
|
The failing DatabaseLoaderTests.Iris* tests (IrisLightGbm, IrisVectorLightGbm, IrisLightGbmWithTimeout, IrisSdcaMaximumEntropy) are failing due to the known LocalDB iris.mdf read-only attach issue tracked in #7657 — they fail independently of this change (my new LoadFromDatabaseLoadsExpectedData test uses in-memory SQLite and is unaffected). Could a maintainer confirm and/or re-run once #7657 is sorted? |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds LoadFromDatabase extension methods on DataOperationsCatalog, mirroring the existing LoadFromTextFile convenience API. This collapses the current three-step database-loading pattern into a single call.
Before:
var loader = mlContext.Data.CreateDatabaseLoader();
var source = new DatabaseSource(SqlClientFactory.Instance, connString, "SELECT * FROM Iris");
var data = loader.Load(source);
After:
var data = mlContext.Data.LoadFromDatabase(SqlClientFactory.Instance, connString, "SELECT * FROM Iris");
LoadFromDatabase(DatabaseSource source)
LoadFromDatabase(DbProviderFactory providerFactory, string connectionString, string commandText)
LoadFromDatabase(DbProviderFactory providerFactory, string connectionString, string commandText, int commandTimeoutInSeconds)
Why this approach
I followed the established LoadFromTextFile pattern in TextLoaderSaverCatalog so the new API stays consistent with the rest of the catalog. The methods simply compose the existing CreateDatabaseLoader() and Load(DatabaseSource) no new loading logic and argument validation is delegated to the existing DatabaseSource constructor.
Tests
Added IrisVectorLightGbmUsingLoadFromDatabase to DatabaseLoaderTests.cs, exercising the new API end-to-end through a LightGBM training pipeline.