Repository navigation
[release/9.0] Remove invalid assert in RSAOpenSsl - #107952
Merged
carlossanlop merged 1 commit intoSep 19, 2024
Merged
carlossanlop merged 1 commit into
carlossanlop merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones |
Sorry, something went wrong.
bartonjs
approved these changes
Sep 17, 2024
jeffhandley
approved these changes
Sep 17, 2024
carlossanlop
approved these changes
Sep 18, 2024
carlossanlop
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
That was a fast fix!
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #107932 to release/9.0
/cc @vcsjones
Customer Impact
Regression
Failing test reported in #107929 and #105715. An assert existed that a particular SafeHandle is valid, however this is not true in a multi-threaded case where the handle is disposed and used concurrently. This assert would occasionally be hit in unit tests.
SafeHandles handle thread safety, correctly, on their own. We should remove the assert and let the ObjectDisposedException from the SafeHandle happen.
Testing
Existing tests continue to pass.
Risk
None / Low. The change removes a Debug.Assert which is only present in Debug builds of Libraries.