Repository navigation
[release/9.0] Fix SG nullability annotations for required and init properties. - #108013
Merged
carlossanlop merged 1 commit intoSep 19, 2024
Merged
carlossanlop merged 1 commit into
carlossanlop merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis |
Sorry, something went wrong.
eiriktsarpalis
requested review from
eiriktsarpalis,
jeffhandley,
jozkee and
krwq
September 19, 2024 12:23
carlossanlop
approved these changes
Sep 19, 2024
carlossanlop
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Approved in Tactics
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
Assignees
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #107985 to release/9.0
/cc @eiriktsarpalis
Customer Impact
Per customer report, the STJ source generator is not filling out nullability metadata for members populated using member initializers (either required or init properties).
Regression
Testing
Added relevant unit testing.
Risk
Low. Updates the source generator to populate a missing property.