Repository navigation
[release/9.0] Fixing SetSlice, Reshape, TryCopyTo. - #108282
Merged
ericstj merged 6 commits intoSep 30, 2024
Merged
ericstj merged 6 commits into
ericstj merged 6 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-numerics-tensors |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
ericstj
approved these changes
Sep 26, 2024
artl93
approved these changes
Sep 26, 2024
This was referenced Oct 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #107852 to release/9.0
/cc @michaelgsharp
Customer Impact
When users call Slice on a TensorSpan, if that slice is not contiguous or dense and then Reshape is called, it can result in the user getting an IndexOutOfRangeException or exposing memory that was initially hidden. Likewise, if the user calls SetSlice on a TensorSpan that is not contiguous or dense, it can result in the user setting bits that were originally hidden from the user. We should not allow this behavior and throw an ArgumentException when Reshape is called in those situations and make sure we set the bits correctly to not touch the hidden bits. See #106539, #106537, and #106535.
Regression
Testing
More automated testing was added to cover the case of non-normal strides combined with slicing. It was missed because its an edge case that wasn't initially thought about.
Risk
Low risk as this is the first time 'Tensor" is being released, its going out in preview state, and we have an end user testing things out as well.