Repository navigation
[release/9.0] [cdac][cdac-build-tool] Don't let msbuild rewrite the resource name - #108296
Merged
jeffschwMSFT merged 3 commits intoOct 3, 2024
Merged
jeffschwMSFT merged 3 commits into
jeffschwMSFT merged 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Work around dotnet/msbuild#9152 Possibly fixes #107936
Copy link
Copy Markdown
Contributor
|
Tagging subscribers to this area: @tommcdon |
Sorry, something went wrong.
jeffschwMSFT
approved these changes
Oct 2, 2024
jeffschwMSFT
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
approved. please get a code review. we can treat this as tell mode.
Sorry, something went wrong.
steveisok
self-requested a review
October 2, 2024 20:30
steveisok
approved these changes
Oct 2, 2024
This was referenced Oct 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #108289 to release/9.0
/cc @lambdageek
Customer Impact
In some Windows environments, building the runtime from source may fail due to the way that MSBuild sometimes rewrites EmbeddedResource items (dotnet/msbuild#9152). This PR mitigates the problem by using a deterministic name
Regression
[If yes, specify when the regression was introduced. Provide the PR or commit if known.]
Testing
Manual testing
Risk
Low. This issue does not manifest on CI/official builds.
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is release/X.0-staging, not release/X.0.
If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.