Repository navigation
[release/9.0] Backport PR #108311 - Fix statics issue with barriers - #108347
Merged
jeffschwMSFT merged 2 commits intoOct 3, 2024
Merged
jeffschwMSFT merged 2 commits into
jeffschwMSFT merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
* Fix statics issue with barriers * Add barriers for RiscV and Loongson
davidwrighton
requested review from
BrzVlad,
MichalStrehovsky,
akoeplinger,
fanyang-mono,
ilonatommy,
jeffhandley,
kg,
kotlarmilos,
lambdageek,
lewing,
maraf,
marek-safar,
pavelsavara,
sbomer,
steveisok and
thaystg
as code owners
September 27, 2024 21:23
Copy link
Copy Markdown
|
Note regarding the new-api-needs-documentation label: This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
Sorry, something went wrong.
1 similar comment
Copy link
Copy Markdown
|
Note regarding the new-api-needs-documentation label: This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
Sorry, something went wrong.
davidwrighton
removed request for
kg,
lewing,
marek-safar,
pavelsavara and
steveisok
September 27, 2024 21:25
davidwrighton
requested review from
EgorBo and
jkotas
and removed request for
BrzVlad,
MichalStrehovsky,
akoeplinger,
fanyang-mono,
ilonatommy,
jeffhandley,
kotlarmilos,
lambdageek,
maraf,
sbomer and
thaystg
September 27, 2024 21:25
EgorBo
approved these changes
Sep 27, 2024
jkotas
approved these changes
Sep 27, 2024
jeffschwMSFT
approved these changes
Sep 27, 2024
jeffschwMSFT
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm. we will take for consideration in 9 GA
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Tagging subscribers to this area: @mangod9 |
Sorry, something went wrong.
This was referenced Oct 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
Assignees
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #108311 to release/9.0
Customer Impact
Applications unexpected crash during startup while attempting to access statics in heavily multithreaded applications. This causes instability for processes which engage in heavily threaded code which has usage of many static variables.
Regression
This was introduced with #99183 , and a previous fix was attempted #105832 . That previous fix was found to be insufficient.
Testing
A new stress test was written by @EgorBo that finally provided a reliable repro case for the failure in #105441 (comment) This reliable repro case was finally found yesterday. Previously we'd only observed the failure in CI, but the manifestation always used a non-live built version of the runtime.
Risk
Medium, additional correctness problems are unexpected, but there may be some performance impact. If this does not fix the issue, further investigation will be needed.
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is release/X.0-staging, not release/X.0.
If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.