Repository navigation
[release/9.0] Fix wrong Region Info Names - #108524
Merged
ericstj merged 2 commits intoOct 3, 2024
Merged
ericstj merged 2 commits into
ericstj merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-globalization |
Sorry, something went wrong.
3 tasks
Copy link
Copy Markdown
Member
|
This is approved by email. |
Sorry, something went wrong.
2 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #108466 to release/9.0
/cc @tarekgh
Customer Impact
[Select one or both of the boxes. Describe how this issue impacts customers, citing the expected and actual behaviors and scope of the issue. If customer-reported, provide the issue number.]
Users trying to create a RegionInfo object using region codes like "AQ", "BV", "CM", "GS", "HM", and "TF" are getting exceptions. This is reported by the Copilot rollout and kind of blocking. We have provided a temporary workaround, but the fix is needed.
Regression
[If yes, specify when the regression was introduced. Provide the PR or commit if known.]
Testing
Manually tested the failure cases and added new tests to cover the failed cases. Also, the change passed the regression tests too.
[How was the fix verified? How was the issue missed previously? What tests were added?]
Risk
Extremely low, we are not changing any real code more than fixing some typos in our region codes data.
[High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.]
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is release/X.0-staging, not release/X.0.
If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.