Repository navigation
[release/9.0-staging] Disable GS cookie checks for LightUnwind - #109530
Merged
jkotas merged 2 commits intoJan 9, 2025
Merged
jkotas merged 2 commits into
jkotas merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
LightUnwind does not track sufficient context to compute GS cookie address Fixes #109242
Copy link
Copy Markdown
Contributor
|
Tagging subscribers to this area: @mangod9 |
Sorry, something went wrong.
jeffschwMSFT
approved these changes
Nov 5, 2024
jeffschwMSFT
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm. we will take for consideration in 9.0.x
Sorry, something went wrong.
janvorli
approved these changes
Nov 5, 2024
janvorli
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM, thank you
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@janvorli can you take a look at the PR failures and merge when ready? |
Sorry, something went wrong.
This was referenced Jan 9, 2025
Open
Copy link
Copy Markdown
Member
|
/ba-g all known infrastructure and test errors |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #109524 to release/9.0-staging
/cc @jkotas
Customer Impact
Runtime crash when Assembly.Load or other APIs that requires stackwalk to find the calling method gets called from a method that uses stackalloc.
Regression
.NET 8 -> .NET 9 regression introduced by #99137 (runtime simplification)
Testing
Regression test added
Risk
Low. The fix is suppressing superfluous sanity checks.