Repository navigation
[release/9.0-staging] Fix transformer handling of boolean schemas in JsonSchemaExporter. - #109975
Merged
jeffhandley merged 2 commits intoNov 26, 2024
Merged
jeffhandley merged 2 commits into
jeffhandley merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis |
Sorry, something went wrong.
jeffhandley
approved these changes
Nov 21, 2024
jeffhandley
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
FYI @artl93
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
/ba-g Errors are known and unrelated |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
Assignees
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #109954 to release/9.0-staging
/cc @eiriktsarpalis
Customer Impact
Reported by an external customer in #109868. Fixes a bug in JsonSchemaExporter that occurs when users apply schema transformers on types with custom converters. It has the potential to produce incorrect schemas under certain circumstances.
Regression
Testing
Added unit testing for the impacted scenario.
Risk
Low. Makes a small and targeted change to product code.