Repository navigation
[release/9.0-staging] Fix System.Reflection.Emit SetChecksum creating invalid pdb - #110205
Merged
ericstj merged 1 commit intoDec 17, 2024
Merged
ericstj merged 1 commit into
ericstj merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-reflection-emit |
Sorry, something went wrong.
ericstj
approved these changes
Nov 27, 2024
ericstj
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM, thank you for including in the test.
Sorry, something went wrong.
artl93
approved these changes
Dec 2, 2024
jeffhandley
approved these changes
Dec 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
Assignees
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #110097 to release/9.0-staging
Fixes #110096.
/cc @steveharter @tgjones
Customer Impact
This is preventing the use of PDBs with source document checksums that allow, for example, the source .cs file to be verified it has not been altered.
Regression
This code was introduced in v9 in this PR which had the bug.
Testing
This PR added the test.
Risk
Low. The fix is straightforward and one LOC.