Repository navigation
[release/9.0-staging] Avoid exception when parsing AD path for port number - #110224
Merged
ericstj merged 1 commit intoDec 17, 2024
Merged
ericstj merged 1 commit into
ericstj merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-directoryservices, @jay98014 |
Sorry, something went wrong.
ericstj
approved these changes
Nov 27, 2024
artl93
approved these changes
Dec 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Assignees
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #109977 to release/9.0-staging
Fixes #109858
Customer Impact
This is breaking existing users of Active Directory through System.DirectoryServices.AccountManagement although there appears to be a workaround.
Regression
Regression in v9 from #89787.
Testing
There is pending community testing.
This is an ActiveDirectory issue which is hard to test since it requires either local usage of AD or a setup of virtual machine(s) to test. There are no automated tests.
Risk
Low; even though the test has not yet been verified the change is to simply change from calling the constructor of the System.Uri class to using System.Uri.TryCreate().