Repository navigation
[release/9.0-staging] [mono][sgen] Add separate card mark function to be used with debug - #110268
Merged
BrzVlad merged 2 commits intoJan 12, 2025
Merged
BrzVlad merged 2 commits into
BrzVlad merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
When marking cards for a non-array object or a an element vt in an object, it is enough to mark a card for any address within that object/vt because they are always fully scanned. Cardtable consistency checks are not accounting for this detail and it is difficult to have it implemented. Instead, when having such debug flags enabled, we use an explicit approach where every single card is being marked.
github-actions
Bot
requested review from
BrzVlad and
lambdageek
as code owners
November 29, 2024 11:53
This was referenced Nov 29, 2024
Copy link
Copy Markdown
Member
|
@BrzVlad please take a look at the PR failures and merge when ready |
Sorry, something went wrong.
BrzVlad
approved these changes
Jan 9, 2025
This was referenced Jan 9, 2025
This was referenced Feb 11, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #109698 to release/9.0-staging
/cc @BrzVlad
Customer Impact
There are existing GC related crashes in the wild, that are currently impossible to investigate. A debug option that might assist this is MONO_GC_DEBUG=check-remset-consistency, however a customer reported that this option reports false positives. This PR fixes these false positives, hopefully assisting in the investigation of aforementioned GC crashes.
Regression
No.
Testing
Manual testing locally.
Risk
Low. This change has no impact unless a certain debug flag is passed, flag which is used for the sole purpose of tracking down GC crashes.