Repository navigation
[release/9.0-staging] [mono][aot] Fix compilation crashes when type load exception is generated in code - #110271
Merged
BrzVlad merged 3 commits intoJan 13, 2025
Merged
BrzVlad merged 3 commits into
BrzVlad merged 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Method compilation was continuing and we ended up failing with invalid IL.
…ption throw In the final stages of method compilation, when trying to compute clause ranges, we were asserting because the clause bblocks haven't been reached for compilation.
Copy link
Copy Markdown
Contributor
|
Tagging subscribers to this area: @steveisok, @vitek-karas |
Sorry, something went wrong.
This was referenced Nov 29, 2024
Copy link
Copy Markdown
Member
|
@BrzVlad please take a look at the PR failures and merge when ready |
Sorry, something went wrong.
This was referenced Jan 9, 2025
Copy link
Copy Markdown
Member
Author
|
needs a review for merging |
Sorry, something went wrong.
lateralusX
self-requested a review
January 13, 2025 11:33
lateralusX
approved these changes
Jan 13, 2025
lateralusX
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM!
Sorry, something went wrong.
This was referenced Feb 11, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
Assignees
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #110078 to release/9.0-staging
Customer Impact
AOT of some assemblies can lead to compilation crashes, on iOS for example. This would force users to use interpreter instead.
Regression
Yes.
Testing
Tested with sample application provided by customer.
Risk
Low. In rare cases, when typeload exception was detected during compile time, we were emitting code to throw this exception at runtime (this was behavior introduced in net9). This functionality had bugs leading to crashes instead during compilation. This PR has impact only on those scenarios that were already crashing.