FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[release/9.0-staging] Don't wait for finalizers in 'IReferenceTrackerHost::ReleaseDisconnectedReferenceSources' by github-actions[bot] · Pull Request #110558 · dotnet/runtime · GitHub

Repository navigation

[release/9.0-staging] Don't wait for finalizers in 'IReferenceTrackerHost::ReleaseDisconnectedReferenceSources' - #110558

Merged
jkotas merged 4 commits into
release/9.0-stagingfrom
backport/pr-110551-to-release/9.0-staging
Jan 8, 2025
Merged

jkotas merged 4 commits into
release/9.0-stagingfrom
backport/pr-110551-to-release/9.0-staging

Conversation

github-actions Bot commented Dec 10, 2024 •
edited by jkotas
Loading

Copy link
Copy Markdown
Contributor

Backport of #110551 to release/9.0-staging

/cc @jkotas @Sergio0694

Customer Impact

  • Customer reported
  • Found internally

Intermittent hang when UWP/WinUI app is suspended. Reported by Windows Store.

Regression

  • Yes
  • No

This is .NET Native -> .NET 9 regression on UWP. The fix updates IReferenceTrackerHost::ReleaseDisconnectedReferenceSources implementation in .NET 9 to match .NET Native (ie reverts the offending change).

Testing

Fix validated on private build by Windows Store

Risk

Low

jkotas commented Dec 10, 2024

Copy link
Copy Markdown
Member

@Sergio0694 Would it be possible to validate the fix by building and testing Windows Store app with NAOT from main?

  • Wait a day for nightly build with the fix to get published
  • Add <add key="dotnet10" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet10/nuget/v3/index.json" /> to your nuget.config
  • Add <add key="dotnet10" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet10/nuget/v3/index.json" /> to your .csproj
  • Build & test

Copy link
Copy Markdown
Contributor

So I managed to get the Store to run on .NET 10 CoreCLR, but ILC is not happy 😅

Perhaps it would be simpler to just test with an SDK build from this branch? Is there a pipeline I can run to get it?

Copy link
Copy Markdown
Member

Weird, this overload was added in #110234, this must be using some AotSdk with an old corelib (and likely old runtime too, without your fix). What are your repro steps?

If you download the latest .NET 10 SDK, it should already have the ILCompiler with your fix. So all that should be needed is to put it in the PATH, add NuGet.config with the .NET 10 feed, update Store to target .NET 10 and that's it.

Copy link
Copy Markdown
Contributor

That's exactly what I did 🥲

Copy link
Copy Markdown
Contributor

Update: I tested again (this time in Release, last time I was trying to run in Debug + Native AOT), and it works! 🎉

I can no longer repro the hangs (no spinning circle on the mouse cursor, no hangs in event viewer), and I can close and reopen the Store multiple times in rapid succession without getting stuck at the OS splash screen (due to the previous instance being hung)!

jkotas commented Dec 14, 2024

Copy link
Copy Markdown
Member

@Sergio0694 Thank you for testing the fix! I have submitted the change into servicing approval process.

jeffschwMSFT left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm. we will take for consideration in 9.0.x

jeffschwMSFT added the Servicing-consider Issue for next servicing release review label Dec 14, 2024
jeffschwMSFT added this to the 9.0.x milestone Dec 14, 2024
jeffschwMSFT added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Jan 6, 2025
jeffschwMSFT modified the milestones: 9.0.x, 9.0.2 Jan 6, 2025

Copy link
Copy Markdown
Member

@jkotas please take a look at the PR failures and merge when ready

jkotas commented Jan 8, 2025

Copy link
Copy Markdown
Member

/ba-g known issue dotnet/dnceng#4756

jkotas merged commit 6cffc15 into release/9.0-staging Jan 8, 2025
jkotas deleted the backport/pr-110551-to-release/9.0-staging branch January 8, 2025 22:30
github-actions Bot locked and limited conversation to collaborators Feb 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Interop-coreclr Servicing-approved Approved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL