Repository navigation
[release/9.0-staging] Fix crash when pTargetMD is null - #110652
Merged
thaystg merged 1 commit intoDec 13, 2024
Merged
thaystg merged 1 commit into
thaystg merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Tagging subscribers to this area: @tommcdon |
Sorry, something went wrong.
tommcdon
approved these changes
Dec 12, 2024
Copy link
Copy Markdown
Member
|
approved offline as this is a regression in a recent fix |
Sorry, something went wrong.
jeffschwMSFT
approved these changes
Dec 13, 2024
jeffschwMSFT
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
Assignees
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #110650 to release/9.0-staging
/cc @thaystg
Customer Impact
It was found internally, it's crashing while debugging an app. It was caused by a backport recently merged: #110438, it's not shipped yet and it's important to fix it before shipping.
Regression
It was introduced here: #110334
Testing
We manually tested.
Risk
Low risk, only checking if a variable is null.
IMPORTANT: If this backport is for a servicing release, please verify that:
Package authoring no longer needed in .NET 9
IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.