FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[release/9.0-staging] Bugfix InvalidOperationException/IndexOutOfRangeException in HttpListener.EndGetContext by github-actions[bot] · Pull Request #110695 · dotnet/runtime · GitHub

  1. dotnet
  2. runtime

Repository navigation

[release/9.0-staging] Bugfix InvalidOperationException/IndexOutOfRangeException in HttpListener.EndGetContext - #110695

Merged
rokonec merged 3 commits into
release/9.0-stagingfrom
backport/pr-107804-to-release/9.0-staging
Jan 10, 2025
ConversationCommits (3)ChecksFiles changed
Merged

[release/9.0-staging] Bugfix InvalidOperationException/IndexOutOfRangeException in HttpListener.EndGetContext #110695
rokonec merged 3 commits into
release/9.0-stagingfrom
backport/pr-107804-to-release/9.0-staging

Conversation

github-actions Bot commented Dec 13, 2024 •
edited by stephentoub
Loading

Copy link
Copy Markdown
Contributor

Backport of #107804 to release/9.0-staging
Fixes #107025

/cc @rokonec @pjannesen

Customer Impact

Reported by customer in #107025. Affects their admin access to services - causes reliability problem.

Regression

From .NET Framework

Testing

Note: The problem is intermittent and hard to reproduce.
Manual testing has been performed - customer validated with private patch prior to submitting .NET 10 PR - see #107025 (comment)

Risk

Low - these simple changes do not add or modify complex logic

ghost added the area-System.Net label Dec 13, 2024

dotnet-policy-service Bot commented Dec 13, 2024

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

rokonec self-assigned this Dec 13, 2024
rokonec mentioned this pull request Dec 13, 2024
Closed
karelz added this to the 9.0.x milestone Dec 17, 2024
karelz reviewed Dec 18, 2024
View reviewed changes

karelz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks like we could have used DisconnectResults directly, there was no need to put it into a variable - that is a cosmetic change.
The real meaningful change is protecting the dictionary from unlocked access - which happened in 2 places.

rokonec approved these changes Dec 18, 2024
View reviewed changes

rokonec left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think it would would work even without using local variable disconnectResults however using it will not harm anything and could have slightly better runtime performance by not calling DisconnectResults getter multiple time.

Changes looks safe and correct to me.

karelz commented Dec 19, 2024

Copy link
Copy Markdown
Member

It is worth fixing in servicing to unblock customers. Marking as such.

karelz added the Servicing-consider Issue for next servicing release review label Dec 19, 2024

pjannesen commented Dec 19, 2024

Copy link
Copy Markdown
Contributor

I think it would would work even without using local variable disconnectResults however using it will not harm anything and could have slightly better runtime performance by not calling DisconnectResults getter multiple time.

The reason behind the local variable is that the getter results in a Volatile.Read. Which makes it more expensive.

rokonec mentioned this pull request Jan 3, 2025
Merged
This was referenced Jan 3, 2025
Open
Open

karelz commented Jan 10, 2025

Copy link
Copy Markdown
Member

Approved by .NET Shiproom (@SteveMCarroll) over email on 1/8. Marking Servicing-approved.

karelz added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Jan 10, 2025
build-analysis Bot mentioned this pull request Jan 10, 2025
Open

rokonec commented Jan 10, 2025

Copy link
Copy Markdown
Member

/ba-g failing flaky tests most probably unrelated to changes of this PR

rokonec merged commit 56501c9 into release/9.0-staging Jan 10, 2025
rokonec deleted the backport/pr-107804-to-release/9.0-staging branch January 10, 2025 19:14
github-actions Bot locked and limited conversation to collaborators Feb 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

karelz karelz left review comments
rokonec rokonec approved these changes
MihaZupan MihaZupan approved these changes
+1 more reviewer
liveans liveans approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

rokonec

Labels

area-System.Net Servicing-approved Approved for servicing release

Projects

None yet

Milestone

9.0.x

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL