Repository navigation
[release/9.0-staging] Change assembler to clang in android MonoAOT - #110812
Merged
jkurdek merged 4 commits intoJan 13, 2025
Merged
jkurdek merged 4 commits into
jkurdek merged 4 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
github-actions
Bot
requested review from
akoeplinger and
marek-safar
as code owners
December 18, 2024 15:08
Copy link
Copy Markdown
Contributor
|
Tagging subscribers to this area: @akoeplinger, @matouskozak |
Sorry, something went wrong.
ivanpovazan
approved these changes
Dec 18, 2024
jkoritzinsky
approved these changes
Dec 18, 2024
This was referenced Dec 18, 2024
Open
github-actions
Bot
force-pushed
the
backport/pr-110393-to-release/9.0-staging
branch
from
09eeeb5 to
b319ecd
Compare
January 7, 2025 13:12
This was referenced Jan 7, 2025
Copy link
Copy Markdown
Contributor
|
/azp run runtime-android, runtime-androidemulator |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
/azp run runtime-extra-platforms |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sorry, something went wrong.
jeffschwMSFT
approved these changes
Jan 9, 2025
jeffschwMSFT
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm. we will take for consideration in 9.0.x
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
/ba-g extra-platforms fails are unrelated |
Sorry, something went wrong.
This was referenced Feb 11, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
Assignees
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #110393 to release/9.0-staging
Customer Impact
This change will allows us to bump NDK version to newer one. This will increase security.
Regression
Testing
This changes were tested with both NDK 23 and NDK 27. Both NDK versions resulted in successful android pipeline runs.
Risk
Low/Medium - this changes the assembler and linker used in android build as per Android official recommendation, this can however result in some unexpected behaviour changes which slipped our tests