FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[release/9.0-staging] Support generic fields in PersistedAssemblyBuilder by github-actions[bot] · Pull Request #110839 · dotnet/runtime · GitHub

  1. dotnet
  2. runtime

Repository navigation

[release/9.0-staging] Support generic fields in PersistedAssemblyBuilder - #110839

Merged
steveharter merged 5 commits into
release/9.0-stagingfrom
backport/pr-110372-to-release/9.0-staging
Jan 15, 2025
ConversationCommits (5)ChecksFiles changed
Merged

[release/9.0-staging] Support generic fields in PersistedAssemblyBuilder#110839
steveharter merged 5 commits into
release/9.0-stagingfrom
backport/pr-110372-to-release/9.0-staging

Conversation

github-actions Bot commented Dec 19, 2024 •
edited by steveharter
Loading

Copy link
Copy Markdown
Contributor

Backport of #110372 to release/9.0-staging

/cc @steveharter

Customer Impact

  • Customer reported
  • Found internally

The new PersistableAssemblyBuilder functionality added in v9 has a bug where generic fields do not generate the proper IL, causing a generic field to be generated as non-generic.

Regression

  • Yes
  • No

This was new functionality added in v9.

Testing

The original author's repro was verified and a test added that inspects the generated field's metadata to make sure the field is generic.

Risk

Low; the fix is fairly straightforward and follows other similar cases where we need to use metadata from open generic types instead of the closed generic type.

dotnet-policy-service Bot commented Dec 19, 2024

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/area-system-reflection-emit
See info in area-owners.md if you want to be subscribed.

teo-tsirpanis added this to the 9.0.x milestone Dec 19, 2024
steveharter self-assigned this Dec 27, 2024
steveharter added the Servicing-consider Issue for next servicing release review label Dec 27, 2024
rbhanda modified the milestones: 9.0.x, 9.0.2 Jan 9, 2025
rbhanda removed the Servicing-consider Issue for next servicing release review label Jan 9, 2025

carlossanlop commented Jan 13, 2025

Copy link
Copy Markdown
Contributor

@steveharter friendly reminder that today's code complete for the Feb 2025 Release. Please merge this change by 4pm PT if you'd like it included in that release version. Otherwise, it will have to wait until next month.

steveharter commented Jan 14, 2025

Copy link
Copy Markdown
Contributor

@rbhanda why was "servicing-consider" removed?

rbhanda added the Servicing-consider Issue for next servicing release review label Jan 14, 2025

carlossanlop commented Jan 14, 2025

Copy link
Copy Markdown
Contributor

@rbhanda I think your intention was to change it to servicing-approved. I can tell because you set the milestone to 9.0.2.

carlossanlop commented Jan 14, 2025

Copy link
Copy Markdown
Contributor

@steveharter if we want this included in the Feb release, I sent you the instructions to Teams. PTAL ASAP.

rbhanda added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Jan 14, 2025
steveharter merged commit e781fb7 into release/9.0-staging Jan 15, 2025
steveharter deleted the backport/pr-110372-to-release/9.0-staging branch January 15, 2025 18:38

carlossanlop commented Jan 15, 2025

Copy link
Copy Markdown
Contributor

/backport to release/9.0

github-actions Bot commented Jan 15, 2025

Copy link
Copy Markdown
Contributor Author

Started backporting to release/9.0: https://github.com/dotnet/runtime/actions/runs/12796250634

github-actions Bot mentioned this pull request Jan 15, 2025
Merged
2 of 4 tasks
github-actions Bot locked and limited conversation to collaborators Feb 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

jkotas jkotas approved these changes
ericstj Awaiting requested review from ericstj
artl93 Awaiting requested review from artl93

Assignees

steveharter

Labels

area-System.Reflection.Emit Servicing-approved Approved for servicing release

Projects

None yet

Milestone

9.0.2

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL