Repository navigation
[release/9.0-staging] Fix wrong alias-to for tvos AOT packs in net8 workload manifest - #110871
Merged
akoeplinger merged 1 commit intoJan 15, 2025
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
(cherry picked from commit a2b10a0)
Copy link
Copy Markdown
Contributor
|
@akoeplinger @lewing friendly reminder that today's code complete for the Feb 2025 Release. Please merge this change by 4pm PT if you'd like it included in that release version. Otherwise, it will have to wait until next month. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Thanks, I emailed tactics for approval, we can get it in for the next cycle. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Approved by tactics via email. |
Sorry, something went wrong.
lewing
approved these changes
Jan 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Customer Impact
While working on #110477 I noticed that we made two mistakes when adding the net8 workload manifest.
This will only show up if you target e.g. net8.0-tvos using a net9 sdk and as far as I know the SDK should fetch the correct package during build, it just won't be pre-downloaded to the sdk packs folder.
Regression
This was introduced in 2d7fe94 but it's only a regression in the sense that it happens when you use the net9 sdk to target net8.0-tvos
Testing
Tested locally by modifying the WorkloadManifest.json and observing the correct pack is installed.
Risk
Low. This just changes the workload manifest for net8 when using a net9 sdk.