Repository navigation
[release/9.0-staging] Fix reporting GC fields from base types - #111040
Merged
jkotas merged 2 commits intoJan 8, 2025
Merged
jkotas merged 2 commits into
jkotas merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
jkotas
approved these changes
Jan 3, 2025
jeffschwMSFT
approved these changes
Jan 6, 2025
jeffschwMSFT
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm. we will take for consideration in 9.0.x
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@MichalStrehovsky please review the PR failures and merge when ready |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
/ba-g Known infrastructure issues with OSX machines |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #111011 to release/9.0-staging
/cc @MichalStrehovsky
Customer Impact
We've been seeing intermittent crashes when running native AOT-compiled ILC in the CI (~5 crashes out of 2000 invocations). This was root caused to a GC hole. The GC hole could be anywhere in user code as well, whenever stack object allocation kicks in. Would affect both native AOT and ReadyToRun (the GC-hole causing miscompilation is in both).
Regression
Introduced in #104411 - we missed updating a spot that was only handling valuetypes but started to be fed reference types as of that PR.
Testing
Verified the fix on another 2000 invocations of ILC with the fix. No more crashes observed. Since the crash is intermittent, we only see it sometimes.
Risk
The risk should be low. The fix was obvious once the bug was root caused (we missed reporting GC fields from base types so the fix is to recurse into bases).
IMPORTANT: If this backport is for a servicing release, please verify that:
Package authoring no longer needed in .NET 9
IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.