FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[release/9.0-staging] [mono] [llvm-aot] Fixed storing Vector3 into memory by github-actions[bot] · Pull Request #111069 · dotnet/runtime · GitHub

  1. dotnet
  2. runtime

Repository navigation

[release/9.0-staging] [mono] [llvm-aot] Fixed storing Vector3 into memory - #111069

Merged
jkurdek merged 2 commits into
release/9.0-stagingfrom
backport/pr-111000-to-release/9.0-staging
Feb 4, 2025
ConversationCommits (2)ChecksFiles changed
Merged

[release/9.0-staging] [mono] [llvm-aot] Fixed storing Vector3 into memory#111069
jkurdek merged 2 commits into
release/9.0-stagingfrom
backport/pr-111000-to-release/9.0-staging

Conversation

github-actions Bot commented Jan 3, 2025 •
edited by jkurdek
Loading

Copy link
Copy Markdown
Contributor

Backport of #111000 to release/9.0-staging. Fixes storing of Vector3 into memory on mono-llvm-aot.

Customer Impact

  • Customer reported
  • Found internally

Reported in #110820. Storing Vector3 into memory was is working incorrectly when using mono aot llvm. Instead of being saved as Vector3 it is saved as Vector4 (Vector3 + trailing 0) effectively overwriting the next memory cell with 0. Customer experienced their data being overwritten with 0s.

Regression

  • Yes
  • No

Regression introduced in #97416. This change implemented some intrinsics for Vector3 - for those intrinsics purposes Vector3 is being represented as Vector4 (Vector3 + 0).

Testing

Added test a new test verifying that saving Vector3 works correctly.

Risk

Low. Change applies only to mono aot llvm Vector3 save to memory path.

ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jan 3, 2025
jkurdek added area-Codegen-LLVM-mono and removed area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labels Jan 3, 2025
jkurdek requested review from matouskozak and tannergooding and removed request for fanyang-mono January 3, 2025 16:55
jkurdek self-assigned this Jan 3, 2025

dotnet-policy-service Bot commented Jan 3, 2025

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @steveisok, @vitek-karas
See info in area-owners.md if you want to be subscribed.

jkurdek commented Jan 3, 2025

Copy link
Copy Markdown
Contributor

/azp run runtime-extra-platforms

dotnet deleted a comment from azure-pipelines Bot Jan 3, 2025

azure-pipelines Bot commented Jan 3, 2025

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

jkurdek requested a review from jeffschwMSFT January 3, 2025 16:56
This was referenced Jan 3, 2025
Open
Open
Open
Open

carlossanlop commented Jan 13, 2025

Copy link
Copy Markdown
Contributor

@jkurdek friendly reminder that today's code complete for the Feb 2025 Release. Please merge this change by 4pm PT if you'd like it included in that release version. Otherwise, it will have to wait until next month.

jeffschwMSFT approved these changes Jan 14, 2025
View reviewed changes

jeffschwMSFT left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm. please get a code review. we will take for consideration in 9.0.x

jeffschwMSFT added the Servicing-consider Issue for next servicing release review label Jan 14, 2025
jeffschwMSFT added this to the 9.0.x milestone Jan 14, 2025
rbhanda modified the milestones: 9.0.x, 9.0.3 Jan 28, 2025
rbhanda added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Jan 28, 2025

jeffschwMSFT commented Jan 30, 2025

Copy link
Copy Markdown
Member

@jkurdek can you take a look at the CI failures? we can merge when ready

jkurdek commented Jan 31, 2025

Copy link
Copy Markdown
Contributor

/azp run runtime-extra-platforms

azure-pipelines Bot commented Jan 31, 2025

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

jkurdek commented Feb 4, 2025

Copy link
Copy Markdown
Contributor

/ba-g runtime-extra-platforms failures are known and unrelated

jkurdek merged commit 2e3dd8e into release/9.0-staging Feb 4, 2025
jkurdek deleted the backport/pr-111000-to-release/9.0-staging branch February 4, 2025 13:05
github-actions Bot locked and limited conversation to collaborators Mar 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

steveisok steveisok approved these changes
jeffschwMSFT jeffschwMSFT approved these changes
matouskozak matouskozak approved these changes
tannergooding Awaiting requested review from tannergooding

Assignees

jkurdek

Labels

area-Codegen-LLVM-mono Servicing-approved Approved for servicing release

Projects

None yet

Milestone

9.0.3

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL