FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[release/9.0-staging] Fix calling convention mismatch in GC callouts by github-actions[bot] · Pull Request #111105 · dotnet/runtime · GitHub

  1. dotnet
  2. runtime

Repository navigation

[release/9.0-staging] Fix calling convention mismatch in GC callouts - #111105

Merged
jeffschwMSFT merged 3 commits into
release/9.0-stagingfrom
backport/pr-110685-to-release/9.0-staging
Jan 8, 2025
ConversationCommits (3)ChecksFiles changed
Merged

[release/9.0-staging] Fix calling convention mismatch in GC callouts#111105
jeffschwMSFT merged 3 commits into
release/9.0-stagingfrom
backport/pr-110685-to-release/9.0-staging

Conversation

github-actions Bot commented Jan 6, 2025 •
edited by AaronRobinsonMSFT
Loading

Copy link
Copy Markdown
Contributor

Backport of #110685 to release/9.0-staging

/cc @AaronRobinsonMSFT @MichalStrehovsky

Customer Impact

  • Customer reported
  • Found internally

The GC will crash in .NET 9 when published with native AOT on win-x86. A GC callback was defined with an incorrect calling convention. This was reported by a customer - #110607.

Related servicing issue: #110815

Regression

  • Yes
  • No

Support for x86_32 was introduced in .NET 9.

Testing

Validated this with the help of Windows Store owners.

Risk

Low

Fix calling convention mismatch in GC callouts
3d03a9e 
Fixes #110607.

The native side expects fastcall.

Filed #110684 on the test hole. We would have caught it during x86 bringup if this had _any_ tests since this is a guaranteed stack corruption and crash.
Change native side instead
fe399fb

dotnet-policy-service Bot commented Jan 6, 2025

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

AaronRobinsonMSFT added the Servicing-consider Issue for next servicing release review label Jan 6, 2025
AaronRobinsonMSFT added this to the 9.0.x milestone Jan 6, 2025
jeffschwMSFT approved these changes Jan 6, 2025
View reviewed changes

jeffschwMSFT left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm. we will take for consideration in 9.0.x

jeffschwMSFT added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Jan 8, 2025
jeffschwMSFT modified the milestones: 9.0.x, 9.0.2 Jan 8, 2025
jeffschwMSFT merged commit 7a95474 into release/9.0-staging Jan 8, 2025
jkotas deleted the backport/pr-110685-to-release/9.0-staging branch January 8, 2025 19:37
This was referenced Jan 8, 2025
Open
Open
github-actions Bot locked and limited conversation to collaborators Feb 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

jkotas jkotas approved these changes
jeffschwMSFT jeffschwMSFT approved these changes
AaronRobinsonMSFT AaronRobinsonMSFT approved these changes
MichalStrehovsky Awaiting requested review from MichalStrehovsky MichalStrehovsky is a code owner

Assignees

No one assigned

Labels

area-NativeAOT-coreclr Servicing-approved Approved for servicing release

Projects

None yet

Milestone

9.0.2

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL