Repository navigation
[debugger] Fix crash during Async Break when APC and CET are enabled - #111408
thaystg merged 13 commits into
Conversation
Sorry, something went wrong.
| FlushProcessWriteBuffers(); | ||
|
|
||
| typedef void (*PAL_ActivationFunction)(CONTEXT *context); | ||
| typedef void (*PAL_ActivationFunction)(CONTEXT *context, bool fromDebugger); |
There was a problem hiding this comment.
A nit - can you please keep this function pointer unchanged and add the following function instead?
void HandleSuspensionForInterruptedThread(CONTEXT *interruptedContext)
{
HandleSuspensionForInterruptedThread(interruptedContext, false);
}
Sorry, something went wrong.
There was a problem hiding this comment.
done
Sorry, something went wrong.
janvorli
left a comment
There was a problem hiding this comment.
LGTM, thank you!
Sorry, something went wrong.
|
/backport to release/9.0-staging |
Sorry, something went wrong.
|
Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/14604017925 |
Sorry, something went wrong.
|
@thaystg backporting to "release/9.0-staging" failed, the patch most likely resulted in conflicts: $ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Applying: Trying to fix crash while funceval after an async break
Applying: Fix call func eval after an async break
error: sha1 information is lacking or useless (src/coreclr/pal/src/exception/signal.cpp).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0002 Fix call func eval after an async break
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
Sorry, something went wrong.
When we are running an APC Callback we are not allowed to SetIP because when APC Callback is resuming it will check if the IP is not changed if CET is enabled.
To avoid this problem we use the APC to suspend the thread, but then we enable the single step and continue the thread execution, this will exit the apc callback and pause in the single step, so we are allowed to SetIP to FuncEvalHijack to run FuncEvals.
Fixes #110552