Repository navigation
[release/9.0-staging] Use alternative format string specifier to ensure decimal point is present - #111444
Merged
jkoritzinsky merged 1 commit intoJan 30, 2025
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT |
Sorry, something went wrong.
jkotas
approved these changes
Jan 15, 2025
This was referenced Jan 15, 2025
Open
jeffschwMSFT
approved these changes
Jan 15, 2025
jeffschwMSFT
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm. we will take for consideration in 9.0.x
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@jkoritzinsky can you take a look at the CI failures? we can merge when ready |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
/ba-g all failures are known |
Sorry, something went wrong.
2 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #111254 to release/9.0-staging
/cc @jkoritzinsky
Customer Impact
ILDasm (9.0) outputs the wrong format in float64(...) and float32(...) for double and float values without decimal places. The decimal point is missing.
ILAsm interprets these as int64 and therefore casts them to double or float values, which leads to incorrect values.
Regression
[If yes, specify when the regression was introduced. Provide the PR or commit if known.]
Regression from .NET 9
Testing
[How was the fix verified? How was the issue missed previously? What tests were added?]
Manual verification
Risk
[High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.]
Low risk. Impacts ildasm usage only and the fix has been validated.
IMPORTANT: If this backport is for a servicing release, please verify that:
Package authoring no longer needed in .NET 9
IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.