FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[browser] Remove experimental args from NodeJS WBT runner by maraf · Pull Request #111655 · dotnet/runtime · GitHub

  1. dotnet
  2. runtime

Repository navigation

[browser] Remove experimental args from NodeJS WBT runner - #111655

Merged
maraf merged 5 commits into
release/9.0-stagingfrom
maraf/BrowserWbtNoExperimentalNodeJS
Feb 10, 2025
ConversationCommits (5)ChecksFiles changed
Merged

[browser] Remove experimental args from NodeJS WBT runner#111655
maraf merged 5 commits into
release/9.0-stagingfrom
maraf/BrowserWbtNoExperimentalNodeJS

Conversation

maraf commented Jan 21, 2025

Copy link
Copy Markdown
Member

The docker image has a newer Node JS which doesn't need the arguments

maraf added arch-wasm WebAssembly architecture area-Infrastructure-mono os-browser Browser variant of arch-wasm labels Jan 21, 2025
maraf added this to the 9.0.x milestone Jan 21, 2025
maraf mentioned this pull request Jan 21, 2025
Merged

dotnet-policy-service Bot commented Jan 21, 2025

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @akoeplinger, @matouskozak
See info in area-owners.md if you want to be subscribed.

akoeplinger commented Jan 21, 2025

Copy link
Copy Markdown
Member

Infrastructure-only change, tell mode, applying servicing-approved.

akoeplinger added the Servicing-approved Approved for servicing release label Jan 21, 2025
This was referenced Jan 21, 2025
Closed
Closed
Closed
Closed
ilonatommy mentioned this pull request Feb 3, 2025
Closed
build-analysis Bot mentioned this pull request Feb 9, 2025
Open
3 tasks

maraf commented Feb 9, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

The Wasm.Build.Tests.ConfigSrcTests.ConfigSrcAbsolutePath faikure is probably related. I'll investigate it
EDIT: It doesn't repro on windows with the same node version. On CI it's just linux
EDIT2: Works also on WSL with the same node version
EDIT3: The test was failing in previous runs. Not related to this change. I'm going to remove the test from running on NodeJS

maraf marked this pull request as ready for review February 10, 2025 12:38
maraf requested a review from ilonatommy as a code owner February 10, 2025 12:38

maraf commented Feb 10, 2025

Copy link
Copy Markdown
Member Author

/ba-g Windows WBT passed on previous run

maraf merged commit 8f76618 into release/9.0-staging Feb 10, 2025
maraf deleted the maraf/BrowserWbtNoExperimentalNodeJS branch February 10, 2025 19:17
maraf mentioned this pull request Feb 17, 2025
Closed

maraf commented Feb 28, 2025

Copy link
Copy Markdown
Member Author

/backport to release/8.0-staging

github-actions Bot commented Feb 28, 2025

Copy link
Copy Markdown
Contributor

Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/13583912155

github-actions Bot mentioned this pull request Feb 28, 2025
Merged
This was referenced Mar 11, 2025
Merged
Merged
Merged
Merged
Merged
maraf mentioned this pull request Mar 21, 2025
Merged
github-actions Bot locked and limited conversation to collaborators Mar 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

lewing lewing approved these changes
akoeplinger akoeplinger approved these changes
ilonatommy ilonatommy approved these changes

Assignees

maraf

Labels

arch-wasm WebAssembly architecture area-Infrastructure-mono os-browser Browser variant of arch-wasm Servicing-approved Approved for servicing release

Projects

None yet

Milestone

9.0.x

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL