Repository navigation
[release/9.0] Remove explicit __compact_unwind entries from x64 assembler - #112204
Merged
jkotas merged 1 commit intoFeb 5, 2025
Merged
jkotas merged 1 commit into
jkotas merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
Sorry, something went wrong.
jkotas
approved these changes
Feb 5, 2025
jkotas
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thank you!
Sorry, something went wrong.
jeffschwMSFT
approved these changes
Feb 5, 2025
jeffschwMSFT
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
approved. we can treat this as tell mode. merge when ready.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #111530 to release/9.0
Ref: dotnet/sdk#46006 (comment)
Customer Impact
Update of Apple build tools to Xcode 16 started producing a warning on some builds in native linker invocation. This affects NativeAOT application builds on macOS machines where Xcode 16 or newer is used. The warnings are suppressed but they indicate a long-standing issue in the code base that surfaced with updated build tooling. We should aim to produce no warning with up-to-date tooling, both on CI pipeline (such as those in dotnet/sdk) and users' machines.
Regression
Testing
The fix was applied on .NET 10 for a while and ingested by various CI pipelines. The object files produced by the native tooling were manually verified. Previously they contained duplicated - identical - records in the compact unwinding section, now the duplicates are no longer produced.
Risk
Low