Repository navigation
Replace bitvector.h/cpp with ptrArgTP type in gc_unwind_x86.h/inl - #112268
jkotas merged 3 commits into
Conversation
Sorry, something went wrong.
|
@jkotas PTAL |
Sorry, something went wrong.
Did you add priority 1 to the build.cmd command line building the tests? The default is pri0 tests only and pri1 won't build. |
Sorry, something went wrong.
| } | ||
| } | ||
|
|
||
| friend BOOL isZero(const ptrArgTP& arg) |
There was a problem hiding this comment.
What are these friends for?
Sorry, something went wrong.
There was a problem hiding this comment.
I took it from the original bitvector. These methods are not used as member methods. I can change it but I wanted to limit the number of changes.
Sorry, something went wrong.
There was a problem hiding this comment.
I meant what does friend modifier on a method implementation do in C++? I am surprised that it compiles, but I cannot think of what it can do.
I would not mind deleting unnecessary cruft. I agree that it is best to avoid any logic changes.
Sorry, something went wrong.
There was a problem hiding this comment.
I think it is basically equivalent to declaring friend BOOL isZero(const ptrArgTP& arg); here and then placing the method itself outside of the struct/class.
Sorry, something went wrong.
|
/azp run runtime-nativeaot-outerloop |
Sorry, something went wrong.
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sorry, something went wrong.
jkotas
left a comment
There was a problem hiding this comment.
Thank you!
Sorry, something went wrong.
* main: (41 commits) Automated bump of chrome version (dotnet#112309) Add `GetDeclaringType` to `PropertyDefinition` and `EventDefinition`. (dotnet#111646) Update the System.ComponentModel.Annotations solution to build in VS (dotnet#112313) JIT: initial support for stack allocating arrays of GC type (dotnet#112250) [main] Update dependencies from dotnet/roslyn (dotnet#112260) Update Xcode casing (dotnet#112307) update the location of assert for REG_ZR check (dotnet#112294) Enable `SA1206`: Keyword ordering (dotnet#112303) Address feedback on dense FrozenDictionary optimization (dotnet#112298) Start regular pri-1 tests runs with native AOT (dotnet#111391) Observe exceptions from _connectionCloseTcs (dotnet#112190) Test failure - SendAsync_RequestVersion20_ResponseVersion20 (dotnet#112232) Fix init race in mono_class_try_get_[shortname]_class. (dotnet#112282) Remove repeated call to DllMain (dotnet#112285) Replace bitvector.h/cpp with ptrArgTP type in gc_unwind_x86.h/inl (dotnet#112268) JIT: Limit 3-opt to 1000 swaps per run (dotnet#112259) [main] Update dependencies from dotnet/icu, dotnet/runtime-assets (dotnet#112120) Update dependencies from https://github.com/dotnet/emsdk build 20250205.3 (dotnet#112223) Fix EventPipe on Android CoreClr. (dotnet#112270) Fix exception handling in the prestub worker (dotnet#111937) ...
Addresses #99109 (comment):
Fixes #112251