Repository navigation
[8.0] Bring back yml necessary change types in label checkers - #114167
Merged
carlossanlop merged 1 commit intoApr 2, 2025
Merged
carlossanlop merged 1 commit into
carlossanlop merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
carlossanlop
requested review from
ViktorHofer,
akoeplinger,
hoyosjs and
jkoritzinsky
April 2, 2025 18:46
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull Request Overview
This backport restores the necessary trigger event types in the label checker workflows to ensure that labeling actions are processed during various pull request events.
- Updated .github/workflows/check-service-labels.yml to add "edited" and "synchronize" event types.
- Updated .github/workflows/check-no-merge-label.yml similarly to include "edited" and "synchronize".
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/check-service-labels.yml | Reintroduces additional trigger events for better label checking behavior in release branches. |
| .github/workflows/check-no-merge-label.yml | Adds the same trigger events for enhanced label checking on main and release branches. |
Sorry, something went wrong.
jkoritzinsky
approved these changes
Apr 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
Assignees
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #114165
Tell mode.
There are some on pull_request_target types in the label checking yml files that I removed but they are actually necessary, so the labeler keeps working after for example: pushing new commits, pressing the update the branch, closing and opening the PR.