FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[release/9.0-staging] Fix ordering issue in interface trimming by github-actions[bot] · Pull Request #114509 · dotnet/runtime · GitHub

  1. dotnet
  2. runtime

Repository navigation

[release/9.0-staging] Fix ordering issue in interface trimming - #114509

Merged
agocke merged 2 commits into
release/9.0-stagingfrom
backport/pr-110098-to-release/9.0-staging
Jul 11, 2025
ConversationCommits (2)ChecksFiles changed
Merged

[release/9.0-staging] Fix ordering issue in interface trimming#114509
agocke merged 2 commits into
release/9.0-stagingfrom
backport/pr-110098-to-release/9.0-staging

Conversation

github-actions Bot commented Apr 10, 2025 •
edited by sbomer
Loading

Copy link
Copy Markdown
Contributor

Backport of #110098 to release/9.0-staging

ProcessMarkedTypesWithInterfaces can lead to additional interface methods being required, so those need to be marked (done by ProcessInterfaceMethods) even if nothing else happens to put new items in the queue.

/cc @sbomer

Customer Impact

  • Customer reported

Reported in #109850. Upon upgrade to .NET 9, application fails with TypeLoadException.

Regression

  • Yes

Regressed in .NET 9 which had substantial changes to the interface trimming logic.

Testing

Validated it fixes the customer-reported issue locally, and the fix has been in .NET 10 since April. Coming up with a small testcase was nontrivial due to the order dependence - given the scope of the change I believe manual validation is sufficient.

Risk

Low. The fix just ensures that we finish processing interface methods, but doesn't change any of the processing logic.

github-actions Bot requested a review from marek-safar as a code owner April 10, 2025 22:44
ghost added the area-Tools-ILLink .NET linker development as well as trimming analyzers label Apr 10, 2025
dotnet-policy-service Bot added the linkable-framework Issues associated with delivering a linker friendly framework label Apr 10, 2025

dotnet-policy-service Bot commented Apr 10, 2025

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/illink
See info in area-owners.md if you want to be subscribed.

This was referenced Apr 11, 2025
Closed
Closed
Open
Open

carlossanlop commented Apr 11, 2025

Copy link
Copy Markdown
Contributor

Friendly reminder that code complete for the may release is next Monday April 14th. If you want this change included in that release, please take it to Tactics and merge the PR before EOD Monday.

jozkee commented May 7, 2025

Copy link
Copy Markdown
Member

@sbomer friendly reminder that code complete is on Monday May 12th (2:00 PM Pacific) for the June Release. If you'd like to get this change included in that release, please get a Tactics approval and merge this PR before the deadline.

jozkee commented Jun 9, 2025

Copy link
Copy Markdown
Member

@sbomer reminder that servicing code complete for 9.0.7 is today @ 3PM PST.

sbomer closed this Jun 9, 2025
sbomer reopened this Jun 9, 2025
sbomer requested review from a team and jtschuster June 9, 2025 18:31
sbomer added the Servicing-consider Issue for next servicing release review label Jun 9, 2025
This was referenced Jun 9, 2025
Open
Closed
steveisok self-requested a review June 10, 2025 13:30
sbomer added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Jun 17, 2025

sbomer commented Jun 17, 2025

Copy link
Copy Markdown
Member

Marking this approved since it was approved over email.

tarekgh commented Jul 10, 2025

Copy link
Copy Markdown
Member

@sbomer are we planning to have this for current release? if so, please ensure merging it soon.

Just reminder Code-complete is 14-Jul 4pm PT cut-off

agocke commented Jul 11, 2025

Copy link
Copy Markdown
Member

/ba-g only failure was infra error ("Agent failed with exception: The machine/process running request 8fe4d16f-53a4-4cf9-ac0c-3bf8809c0675 restarted. Agents can't recover from restarts.")

agocke merged commit ccf556d into release/9.0-staging Jul 11, 2025
agocke deleted the backport/pr-110098-to-release/9.0-staging branch July 11, 2025 00:57
This was referenced Aug 7, 2025
Closed
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Merged
Merged
Closed
Closed
Closed
Closed
Merged
Closed
Merged
Merged
Merged
Merged
Closed
Closed
Merged
Merged
Closed
Closed
Closed
github-actions Bot locked and limited conversation to collaborators Aug 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

steveisok steveisok approved these changes
jtschuster jtschuster approved these changes
marek-safar Awaiting requested review from marek-safar marek-safar is a code owner

Assignees

No one assigned

Labels

area-Tools-ILLink .NET linker development as well as trimming analyzers linkable-framework Issues associated with delivering a linker friendly framework Servicing-approved Approved for servicing release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL