FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[release/9.0-staging] [wasm] Read messages from binlog if process output is missing build finished message by maraf · Pull Request #114676 · dotnet/runtime · GitHub

  1. dotnet
  2. runtime

Repository navigation

[release/9.0-staging] [wasm] Read messages from binlog if process output is missing build finished message - #114676

Merged
maraf merged 2 commits into
dotnet:release/9.0-stagingfrom
maraf:WbtDebugMissingMicrosoftNetCoreAppRuntimePackDir90
Apr 19, 2025
ConversationCommits (2)ChecksFiles changed
Merged

[release/9.0-staging] [wasm] Read messages from binlog if process output is missing build finished message#114676
maraf merged 2 commits into
dotnet:release/9.0-stagingfrom
maraf:WbtDebugMissingMicrosoftNetCoreAppRuntimePackDir90

Conversation

maraf commented Apr 15, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Manual backport of #107280.
Mitigates #106160.

Infrastructure only change.

maraf added arch-wasm WebAssembly architecture test-enhancement Improvements of test source code area-Infrastructure-mono labels Apr 15, 2025
maraf added this to the 9.0.x milestone Apr 15, 2025
maraf self-assigned this Apr 15, 2025

dotnet-policy-service Bot commented Apr 15, 2025

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @akoeplinger, @matouskozak
See info in area-owners.md if you want to be subscribed.

This was referenced Apr 15, 2025
Open
Closed
Closed
maraf closed this Apr 15, 2025
maraf reopened this Apr 15, 2025
This was referenced Apr 15, 2025
Open
Closed
maraf marked this pull request as ready for review April 16, 2025 09:05
Copilot AI review requested due to automatic review settings April 16, 2025 09:05
maraf requested a review from ilonatommy as a code owner April 16, 2025 09:05
Copilot AI reviewed Apr 16, 2025
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.

Files not reviewed (2)
  • eng/Versions.props: Language not supported
  • src/mono/wasm/Wasm.Build.Tests/Wasm.Build.Tests.csproj: Language not supported
Comments suppressed due to low confidence (2)

src/mono/wasm/Wasm.Build.Tests/BuildTestBase.cs:180

  • Consider adding test cases to cover scenarios where the process output is replaced with binlog messages to ensure this new logic behaves as expected.
// Ensure we got all output.

src/mono/wasm/Wasm.Build.Tests/BuildTestBase.cs:188

  • [nitpick] Consider renaming 'buildRoot' to 'binlogRoot' for enhanced clarity that this variable represents the parsed binary log.
var buildRoot = BinaryLog.ReadBuild(logFilePath);

maraf commented Apr 16, 2025
View reviewed changes
Comment thread eng/Versions.props
Comment on lines +265 to +266
<!-- <SdkVersionForWorkloadTesting>$(MicrosoftDotNetApiCompatTaskVersion)</SdkVersionForWorkloadTesting> -->
<SdkVersionForWorkloadTesting>9.0.105</SdkVersionForWorkloadTesting>

maraf Apr 16, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@akoeplinger Should I merge this in to avoid non-existent 9.0.106 or do we handle it separately?

akoeplinger Apr 16, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

yeah we're doing it as part of #114700 too. not sure when that PR will go in.

maraf requested a review from akoeplinger April 16, 2025 09:06
maraf added the Servicing-approved Approved for servicing release label Apr 16, 2025
maraf closed this Apr 16, 2025
maraf reopened this Apr 16, 2025
This was referenced Apr 16, 2025
Closed
Closed
Closed
Closed
maraf removed the Servicing-approved Approved for servicing release label Apr 17, 2025
maraf added Servicing-approved Approved for servicing release and removed Servicing-approved Approved for servicing release labels Apr 17, 2025

maraf commented Apr 19, 2025

Copy link
Copy Markdown
Member Author

/ba-g CI failures are unrelated, passed on previous run

maraf merged commit 20e7f60 into dotnet:release/9.0-staging Apr 19, 2025
maraf deleted the WbtDebugMissingMicrosoftNetCoreAppRuntimePackDir90 branch April 19, 2025 07:49
github-actions Bot locked and limited conversation to collaborators May 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
akoeplinger akoeplinger approved these changes
ilonatommy Awaiting requested review from ilonatommy ilonatommy is a code owner

Assignees

maraf

Labels

arch-wasm WebAssembly architecture area-Infrastructure-mono Servicing-approved Approved for servicing release test-enhancement Improvements of test source code

Projects

None yet

Milestone

9.0.x

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL