FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Disable the UTFStringConversionFailures test on CI runs by jkoritzinsky · Pull Request #114747 · dotnet/runtime · GitHub

Repository navigation

Disable the UTFStringConversionFailures test on CI runs - #114747

Merged
jkoritzinsky merged 2 commits into
dotnet:mainfrom
jkoritzinsky:skip-large-string-ci
Apr 17, 2025
Merged

jkoritzinsky merged 2 commits into
dotnet:mainfrom
jkoritzinsky:skip-large-string-ci

Conversation

Copy link
Copy Markdown
Member

Disable the UTFStringConversionFailures test on CI runs as our Helix machines can't handle the load from allocating 2 2GB strings and the OOM killer was killing the process.

Fixes #114241

…machines can't handle the load from allocating 2 2GB strings and the OOM killer was killing the process.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.Tests/CollectionMarshallingFails.cs:113

  • Disabling the test reduces CI coverage; please ensure that issue #114241 tracks plans for addressing this or running the test in a memory-optimized environment.
[SkipOnCI("Allocates enough memory that the OOM killer can kill the process on our Helix machines.")]

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

{
[Fact]
[SkipOnCI("Allocates enough memory that the OOM killer can kill the process on our Helix machines.")]
public void UTFStringConversionFailures()

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Would it make sense to name this as something specific to conversion failures due to the long string?

Copy link
Copy Markdown
Member Author

/ba-g wasm failures unrelated

jkoritzinsky merged commit ce3c9df into dotnet:main Apr 17, 2025
github-actions Bot locked and limited conversation to collaborators May 17, 2025
dotnet unlocked this conversation Jun 10, 2025

Copy link
Copy Markdown
Member Author

/backport to release/9.0-staging

Copy link
Copy Markdown
Contributor

Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/15550434935

agocke commented Jul 10, 2025

Copy link
Copy Markdown
Member

/backport to release/8.0-staging

Copy link
Copy Markdown
Contributor

Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/16183337745

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SIGKILL (OOM?) while running LibraryImportGenerator.Tests w/o actionable log messages or artifacts

5 participants


Back | FazBrowse Home | New Git URL