Repository navigation
[Test Only] Fix Idn tests - #115032
Merged
tarekgh merged 2 commits intoApr 26, 2025
Merged
[Test Only] Fix Idn tests#115032tarekgh merged 2 commits into
tarekgh merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes IDN tests by incorporating updated Unicode 16.0 test data and adjusting ICU version checks accordingly.
- Introduces a new test class for Unicode 16.0 IDNA mapping.
- Updates ICU version conditions in the factory and test result classes.
- Adds documentation for the new Unicode 16.0 test data.
Reviewed Changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated no comments.
Show a summary per file| File | Description |
|---|---|
| Unicode_16_0_IdnaTest.cs | New test implementation for Unicode 16.0 data |
| ReadMe.txt | Documentation updated with Unicode 16.0 details |
| Factory.cs | Revised ICU version checks to reference Unicode 16.0 data |
| ConformanceIdnaUnicodeTestResult.cs | Adds a new constructor overload for handling source data |
| ConformanceIdnaTestResult.cs | Introduces a new source parameter and enhances validation via IsIgnorableA4_2Rule |
- src/libraries/System.Runtime/tests/System.Globalization.Extensions.Tests/NlsTests/System.Globalization.Extensions.Nls.Tests.csproj: Language not supported
- src/libraries/System.Runtime/tests/System.Globalization.Extensions.Tests/System.Globalization.Extensions.Tests.csproj: Language not supported
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-globalization |
Sorry, something went wrong.
carlossanlop
approved these changes
Apr 25, 2025
carlossanlop
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Tell mode.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
+1 more reviewerAssignees
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.