Repository navigation
[release/8.0-staging] Handle OSSL 3.4 change to SAN:othername formatting - #115367
bartonjs merged 1 commit into
Conversation
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
Backport to accommodate the change in SAN otherName formatting introduced by OpenSSL 3.4.
- Add detection for OpenSSL 3.4 in PlatformDetection
- Update the test for Subject Alternative Name formatting to handle the new OpenSSL 3.4 output
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/libraries/System.Security.Cryptography/tests/AsnEncodedDataTests.cs | Add IsOpenSsl3_4 flag and adjust expected SAN formatting |
| src/libraries/Common/tests/TestUtilities/System/PlatformDetection.Unix.cs | Introduce IsOpenSsl3_4, refactor OpenSSL version checks |
Sorry, something went wrong.
|
Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones |
Sorry, something went wrong.
|
Why didn't this backport cleanly? Because in 9.0 we renamed IsOSXLike to IsApplePlatform, which changed how we ask what version of OpenSSL the platform is running. #96098 |
Sorry, something went wrong.
|
Test-only change, no servicing review required. |
Sorry, something went wrong.
Backport of #111820 to release/8.0-staging
/cc @vcsjones @bartonjs
Customer Impact
This is a test-only change to react to a change in OpenSSL 3.4 that is starting to appear in our CI pipelines. OpenSSL 3.4 formats a UPN in an otherName SAN differently.
Regression
Reacting to an upstream change in OpenSSL 3.4 that was introduced here openssl/openssl@de8861a
Testing
Existing tests caught the change. Tests pass after conditionally handling the OpenSSL 3.4 change, so that tests will continue to pass on older OpenSSL versions, too.
Risk
Low. Test only change.
IMPORTANT: If this backport is for a servicing release, please verify that: