Repository navigation
[release/8.0-staging] throw an exception instead of infinite loop in sort_mark_list - #115528
Merged
Maoni0 merged 1 commit intoMay 22, 2025
Merged
Maoni0 merged 1 commit into
Maoni0 merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
jeffschwMSFT
approved these changes
May 13, 2025
jeffschwMSFT
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm. we will take for consideration in 8.0.x
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #115492 to release/8.0-staging
/cc @Maoni0
Customer Impact
infinite loops are bad for prod diag and they'd prefer a crash.
Regression
Testing
it's a request to help make it easier for prod diag. I've tested that this does throw an exception if that condition is hit..
Risk
low
IMPORTANT: If this backport is for a servicing release, please verify that:
Package authoring no longer needed in .NET 9
IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.