| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
@dotnet/jit-contrib PTAL |
Sorry, something went wrong.
@AndyAyersMS Is that situation applicable to the repro in #116180 or just the older case? I tried changing code around in the repro case to avoid this issue but haven't been able to (trying to find a workaround until this is released in servicing). |
Sorry, something went wrong.
To the repro. I tried various source manipulations there with no luck. It is not just that the return value is ignored; it's also that the JIT can prove that the cast to IDisposable will fail and so removes that whole bit of code, and that the return value can be trivially predicted from the argument, so when all this is inlined it creates this odd orphaned local reference that trips up forward sub. |
Sorry, something went wrong.
|
Ah, gotcha, thanks for the explanation. |
Sorry, something went wrong.
There was a problem hiding this comment.
lgtm. we will take for consideration in 8.0.x
Sorry, something went wrong.
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Backport of #99546 to release/8.0-staging
/cc @AndyAyersMS @SingleAccretion
Customer Impact
JIT crash reported in #116180
Related to calling methods that return values and then ignoring those return values.
Regression
Not 100% sure, but seemingly a hard to hit bug that's been there a while. This phase was first added in .NET 7.
Testing
Verified the fix on the repro case in the issue.
Risk
Low. Fix was added to .NET 9 before release.