FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[release/8.0-staging] Add a parent check to the forward substitution tree walk by github-actions[bot] · Pull Request #116240 · dotnet/runtime · GitHub

Repository navigation

[release/8.0-staging] Add a parent check to the forward substitution tree walk - #116240

Merged
AndyAyersMS merged 2 commits into
release/8.0-stagingfrom
backport/pr-99546-to-release/8.0-staging
Jun 4, 2025
Merged

AndyAyersMS merged 2 commits into
release/8.0-stagingfrom
backport/pr-99546-to-release/8.0-staging

Conversation

github-actions Bot commented Jun 3, 2025 •
edited by AndyAyersMS
Loading

Copy link
Copy Markdown
Contributor

Backport of #99546 to release/8.0-staging

/cc @AndyAyersMS @SingleAccretion

Customer Impact

  • Customer reported
  • Found internally

JIT crash reported in #116180

Related to calling methods that return values and then ignoring those return values.

Regression

  • Yes
  • No

Not 100% sure, but seemingly a hard to hit bug that's been there a while. This phase was first added in .NET 7.

Testing

Verified the fix on the repro case in the issue.

Risk

Low. Fix was added to .NET 9 before release.

Copy link
Copy Markdown
Member

@dotnet/jit-contrib PTAL

adityamandaleeka commented Jun 3, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Related to calling methods that return values and then ignoring those return values.

@AndyAyersMS Is that situation applicable to the repro in #116180 or just the older case? I tried changing code around in the repro case to avoid this issue but haven't been able to (trying to find a workaround until this is released in servicing).

Copy link
Copy Markdown
Member

Related to calling methods that return values and then ignoring those return values.

@AndyAyersMS Is that situation applicable to the repro in #116180 or just the older case? I tried changing code around in the repro case to avoid this issue but haven't been able to (trying to find a workaround until this is released in servicing).

To the repro. I tried various source manipulations there with no luck.

It is not just that the return value is ignored; it's also that the JIT can prove that the cast to IDisposable will fail and so removes that whole bit of code, and that the return value can be trivially predicted from the argument, so when all this is inlined it creates this odd orphaned local reference that trips up forward sub.

Copy link
Copy Markdown
Member

Ah, gotcha, thanks for the explanation.

jeffschwMSFT left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm. we will take for consideration in 8.0.x

jeffschwMSFT added Servicing-consider Issue for next servicing release review area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labels Jun 3, 2025
jeffschwMSFT added this to the 8.0.x milestone Jun 3, 2025

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

rbhanda modified the milestones: 8.0.x, 8.0.18 Jun 3, 2025
rbhanda added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Jun 3, 2025
AndyAyersMS merged commit 0e6061f into release/8.0-staging Jun 4, 2025
AndyAyersMS self-assigned this Jun 4, 2025
jkotas deleted the backport/pr-99546-to-release/8.0-staging branch June 8, 2025 13:02
github-actions Bot locked and limited conversation to collaborators Jul 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI Servicing-approved Approved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants


Back | FazBrowse Home | New Git URL