Repository navigation
[release/8.0-staging] Fix return in zlib-intel when window allocation fails - #116550
Merged
ericstj merged 1 commit intoJun 13, 2025
Merged
ericstj merged 1 commit into
ericstj merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a reliability issue by ensuring inflate.c returns Z_MEM_ERROR immediately when window allocation fails, allowing the proper exception to surface instead of leading to a crash.
- Converted deferred ret = Z_MEM_ERROR assignments to immediate return Z_MEM_ERROR in two error paths.
- Ensures out-of-memory conditions produce the correct error response in zlib-intel on Windows.
src/native/external/zlib-intel/inflate.c:254
- Add or update unit tests to simulate window allocation failures and verify that Z_MEM_ERROR is returned and a ZlibException is thrown as expected.
return Z_MEM_ERROR;
src/native/external/zlib-intel/inflate.c:730
- Ensure tests cover this second allocation failure path to confirm consistent error handling in both branches.
return Z_MEM_ERROR;
Sorry, something went wrong.
jkotas
approved these changes
Jun 11, 2025
AaronRobinsonMSFT
approved these changes
Jun 11, 2025
Copy link
Copy Markdown
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-io-compression |
Sorry, something went wrong.
3 tasks
ericstj
enabled auto-merge (squash)
June 12, 2025 15:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
Assignees
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Customer Impact
If a process is running low on memory and fails window allocation in zlib on Windows, we weren't correctly returning the error to produce the correct ZlibException. This creates a reliability issue as the failure looks like an application crash instead of out of memory. This issue is unique to the zlib-intel codebase.
Regression
Testing
Unit tests, adhoc testing.
Risk
Low. This is likely a non-recoverable error, we're just making sure we surface in a way that diagnostics will correctly capture.