Repository navigation
[release/9.0-staging] Fix ILogB for subnormal values - #116973
Merged
tannergooding merged 2 commits intoJul 10, 2025
Merged
tannergooding merged 2 commits into
tannergooding merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@tannergooding Can you help to fill the description for backport? I don't have permission to edit pull requests. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-numerics |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Are we good to merge this? Just reminder Code-complete is 14-Jul 4pm PT cut-off |
Sorry, something went wrong.
tannergooding
approved these changes
Jul 10, 2025
This was referenced Aug 5, 2025
This was referenced Aug 19, 2025
Bump Microsoft.Extensions.DependencyInjection from 9.0.3 to 9.0.8
wiktoraleksanderkaczor/repotool#18
Closed
Merged
Merged
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #116913 to release/9.0-staging
/cc @jeffhandley @huoyaoyuan
Customer Impact
Customers calling ILogB for certain subnormal values will get incorrect results.
Regression
This was introduced in #98040 as part of a general performance refactoring. The ilogb algorithm was ported from amd/aocl-libm-ose and a while loop was ported to TrailingZeroCount when it should've used LeadingZeroCount instead.
Testing
Explicit regression tests were added and validated against the native C libm implementation.
Risk
Low. This is a small fix for an edge case that is not found in typical code.