FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Disable odbc tests on net9 interpreter by BrzVlad · Pull Request #117245 · dotnet/runtime · GitHub

  1. dotnet
  2. runtime

Repository navigation

Disable odbc tests on net9 interpreter - #117245

Merged
BrzVlad merged 1 commit into
dotnet:release/9.0-stagingfrom
BrzVlad:disable-odbc-interp-9.0
Jul 8, 2025
ConversationCommits (1)ChecksFiles changed
Merged

Disable odbc tests on net9 interpreter#117245
BrzVlad merged 1 commit into
dotnet:release/9.0-stagingfrom
BrzVlad:disable-odbc-interp-9.0

Conversation

BrzVlad commented Jul 2, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Copilot AI review requested due to automatic review settings July 2, 2025 15:18

dotnet-policy-service Bot commented Jul 2, 2025

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @BrzVlad, @kotlarmilos
See info in area-owners.md if you want to be subscribed.

Copilot AI reviewed Jul 2, 2025
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Pull Request Overview

This PR disables a set of ODBC integration tests on the Mono interpreter (net9) by marking them with an ActiveIssue attribute.

  • Adds [ActiveIssue(..., PlatformDetection.IsMonoInterpreter)] to individual test methods.
  • Targets tests across multiple files to skip them until issue #116482 is addressed.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
src/libraries/System.Data.Odbc/tests/SmokeTest.cs Marked CreateInsertSelectTest with ActiveIssue
src/libraries/System.Data.Odbc/tests/ReaderTests.cs Added ActiveIssue to several reader-related test methods
src/libraries/System.Data.Odbc/tests/DependencyCheckTest.cs Marked dependency-check test with ActiveIssue
src/libraries/System.Data.Odbc/tests/ConnectionTests.cs Added ActiveIssue to connection test
src/libraries/System.Data.Odbc/tests/CommandBuilderTests.cs Marked command-builder tests with ActiveIssue

Comment thread src/libraries/System.Data.Odbc/tests/SmokeTest.cs
Comment thread src/libraries/System.Data.Odbc/tests/ReaderTests.cs
Comment thread src/libraries/System.Data.Odbc/tests/DependencyCheckTest.cs
Comment thread src/libraries/System.Data.Odbc/tests/ConnectionTests.cs
Comment thread src/libraries/System.Data.Odbc/tests/CommandBuilderTests.cs

BrzVlad commented Jul 2, 2025

Copy link
Copy Markdown
Member Author

@ericstj @akoeplinger This is just for green CI on .net9. What would be the process with this ? Does it need to go through normal tactics approval like normal fixes ?

akoeplinger commented Jul 2, 2025

Copy link
Copy Markdown
Member

Test-only changes are tell-mode.

akoeplinger added the Servicing-approved Approved for servicing release label Jul 2, 2025

ericstj commented Jul 7, 2025

Copy link
Copy Markdown
Member

@BrzVlad you're free to merge this.

BrzVlad merged commit f1308f0 into dotnet:release/9.0-staging Jul 8, 2025
This was referenced Aug 5, 2025
Merged
Merged
Merged
Closed
Closed
Open
Merged
Merged
Closed
Open
Closed
Merged
Merged
Merged
Closed
Closed
Closed
Merged
This was referenced Aug 7, 2025
Merged
Merged
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Open
Closed
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Merged
Merged
Closed
Closed
Closed
Closed
Merged
Closed
Merged
github-actions Bot locked and limited conversation to collaborators Aug 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
akoeplinger akoeplinger approved these changes

Assignees

BrzVlad

Labels

area-Codegen-Interpreter-mono Servicing-approved Approved for servicing release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL