Repository navigation
[release/9.0-staging] Revert "Remove custom allocator." - #118279
Merged
ericstj merged 7 commits intoAug 12, 2025
Merged
ericstj merged 7 commits into
ericstj merged 7 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This reverts commit c62bc5b.
Copy link
Copy Markdown
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-io-compression |
Sorry, something went wrong.
This was referenced Aug 1, 2025
jkotas
approved these changes
Aug 1, 2025
Copy link
Copy Markdown
Member
|
/ba-g unrelated test failures |
Sorry, something went wrong.
This was referenced Sep 9, 2025
Closed
This was referenced Sep 25, 2025
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #117949 to release/9.0-staging
/cc @ericstj
Customer Impact
The performance of compression on .NET 9.0 was degraded in large production applications running on Windows with many concurrent operations. We tracked down the cause of the regression as due to heap fragmentation and increased CPU time spent when trying to allocate memory in zlib-ng.
Regression
Regression introduced in .NET 9.0 RC2 -- c62bc5b #105771
Testing
Benchmark created, verified fixed with the change. Customer validated fix as well.
Benchmarks will be added to performance repo if they can be made reliable. This issue issue is difficult to test as it relies on stress scenarios.
Risk
Low. We've done a lot of validation of this. We've shipped with this functionality present in the past.