FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Devirtualize more based on whole program analysis by MichalStrehovsky · Pull Request #97812 · dotnet/runtime · GitHub

Repository navigation

Devirtualize more based on whole program analysis - #97812

Merged
MichalStrehovsky merged 1 commit into
dotnet:mainfrom
MichalStrehovsky:betterdevirt
Feb 1, 2024
Merged

MichalStrehovsky merged 1 commit into
dotnet:mainfrom
MichalStrehovsky:betterdevirt

Conversation

Copy link
Copy Markdown
Member

Whole program view lets us figure out whether a virtual method has been overriden by another method, or whether it can be considered final. Add a pass to collect this information and pass it to codegen,

It kicks in less often than I expected (for linear enough hierarchies or not-too-much-derived types we could already do this with guarded devirtualization or type sealing), but I can still a bit over 100 method bodies affected by this in the Stage1 app.

Cc @dotnet/ilc-contrib

Whole program view lets us figure out whether a virtual method has been overriden by another method, or whether it can be considered `final`. Add a pass to collect this information and pass it to codegen,

It kicks in less often than I expected (for linear enough hierarchies or not-too-much-derived types we could already do this with guarded devirtualization or type sealing), but I can still a bit over 100 method bodies affected by this in the Stage1 app.

ghost commented Feb 1, 2024

Copy link
Copy Markdown

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

Whole program view lets us figure out whether a virtual method has been overriden by another method, or whether it can be considered final. Add a pass to collect this information and pass it to codegen,

It kicks in less often than I expected (for linear enough hierarchies or not-too-much-derived types we could already do this with guarded devirtualization or type sealing), but I can still a bit over 100 method bodies affected by this in the Stage1 app.

Cc @dotnet/ilc-contrib

Author: MichalStrehovsky
Assignees: MichalStrehovsky
Labels:

area-NativeAOT-coreclr

Milestone: -

Copy link
Copy Markdown
Member Author

/azp run runtime-nativeaot-outerloop

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

jkotas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL