fixed last_heartbeat function - #1023
Open
tridge wants to merge 1 commit into
Open
tridge wants to merge 1 commit into
tridge wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
this should return the time since the last heartbeat, but instead it was giving the time between the last hearbeat and the last mavlink pkt. That means if you lose link completely then last_heartbeat wouldn't update
tridge
marked this pull request as draft
April 23, 2020 00:53
tridge
marked this pull request as ready for review
April 23, 2020 02:27
Copy link
Copy Markdown
Collaborator
Author
|
testing passed |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this should return the time since the last heartbeat, but instead it
was giving the time between the last hearbeat and the last mavlink
pkt. That means if you lose link completely then last_heartbeat
wouldn't update
This is pending testing