Review round 2 fixes: cancellation-safe lifecycle, bounded shutdown, identity checks - #4
Open
tomasvarga wants to merge 3 commits into
Open
tomasvarga wants to merge 3 commits into
tomasvarga wants to merge 3 commits into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
- create/delete run as driver-owned tasks: cancelling the gateway request can't abandon provisioning or cleanup; duplicate creates are rejected - delete keeps a 'deleting' record (visible, blocks concurrent deletes) and removes + announces only after E2B confirms; failures stay visible - failed create rollbacks go on a leaked list the health loop keeps retrying - health: judge only boxes known before the E2B query (no false 'gone') - bounded shutdown on SIGINT/SIGTERM: stop helpers, kill E2B boxes, exit - reject workload identities other than sandbox/1500 in Validate and Create - socat step fails if the runtime socket never appears - spike negative-test client verifies the certificate too - watch: a fence failure is no longer shown as success - control template pins e2b@2.51.0; demo.sh asserts 200/403/denied with bounded waits and always cleans up; README and end card claims made precise
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up to #1, which was merged before its second review round landed. These three commits were pushed to the #1 branch after the merge, so they aren't on main yet. The #1 description already describes them.
Changes
Driver (Codex gpt-6-astra, round 2)
Scripts and docs
./media/demo.mp4
Verified live on E2B
- npm run demo passes all assertions against the rebuilt driver (create and delete through the new tasks).
- SIGTERM with the gateway's watch open: supervisors 1 → 0, E2B boxes 1 → 0, driver exited.
- cargo clippy (pedantic + nursery, unwrap/expect denied) clean; cargo test 3 passed.
demo.mp4