fix(envd): serve actual content for procfs/sysfs files with size=0 - #3664
Open
dajiaohuang wants to merge 1 commit into
Open
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
When stat.Size() returns 0 for virtual files like procfs/sysfs, http.ServeContent uses seek to determine size and sets Content-Length: 0, causing empty responses. The gzip path works because io.Copy streams content directly without seeking. Fix by reading size=0 files into memory (capped at 64 KiB) and serving via bytes.Reader through http.ServeContent, preserving Range/conditional request semantics while returning actual content. Fixes e2b-dev#3363
dajiaohuang
requested review from
ValentaTomas,
dobrac and
jakubno
as code owners
September 25, 2026 08:34
Copy link
Copy Markdown
|
We require contributors to sign our Contributor License Agreement, and we don't have @dajiaohuang on file. You can sign our CLA at https://e2b.dev/docs/cla . Once you've signed, post a comment here that says '@cla-bot check' |
Sorry, something went wrong.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
At least 1 approving review is required to merge this pull request.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When stat.Size() returns 0 for virtual files like procfs/sysfs (e.g., /proc/sys/kernel/random/boot_id), http.ServeContent uses seek to determine size and sets Content-Length: 0, causing empty responses. The gzip path works because io.Copy streams content directly without seeking.
Fix
Read size=0 files into memory (capped at 64 KiB) and serve via bytes.Reader through http.ServeContent, preserving Range/conditional request semantics while returning actual content.
Testing
Related issue
Fixes #3363