Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds scale support to Decimal128 data types in the e6data Python connector. The main purpose is to enhance decimal precision handling by adding a scale parameter to both data structures and constant data structures for Decimal128 values.
Key changes:
- Added scale field to Decimal128Data and NumericDecimal128ConstantData structures in Thrift definitions
- Updated Python code to handle the new scale parameter in decimal conversion functions
- Enhanced debugging capabilities with comprehensive logging configuration
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file| File | Description |
|---|---|
| e6x_vector.thrift | Added scale field (i32) to Decimal128Data and NumericDecimal128ConstantData structs |
| e6data_python_connector/e6x_vector/ttypes.py | Updated generated Thrift classes to include scale parameter handling in constructors, read/write methods, and thrift_spec |
| e6data_python_connector/e6data_grpc.py | Added comprehensive debug logging configuration with gRPC tracing support |
| e6data_python_connector/datainputstream.py | Modified decimal conversion functions to accept and use scale parameter for proper decimal precision |
| README.md | Added debugging and troubleshooting documentation section |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sorry, something went wrong.
Comment thread
e6data_python_connector/e6data_grpc.py
Comment thread
e6data_python_connector/e6data_grpc.py
Comment thread
e6data_python_connector/datainputstream.py
Yashraje6x
approved these changes
Oct 8, 2025
Yashraje6x
left a comment
Copy link
Copy Markdown
There was a problem hiding this comment.
Approved
Sorry, something went wrong.
AKASHSE-123
approved these changes
Oct 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.