Redesign async client - #361
Open
Miq1 wants to merge 15 commits into
Open
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Use ticker instead of onPoll to harmonize polling between esp8266 and esp32
Copy link
Copy Markdown
Contributor
|
The compilation issues are an easy fix. I will prepare a PR into the redesign branch. |
Sorry, something went wrong.
* remove lock from state * rename variable 'queue' * fix brackets * pop_front --> pop
Copy link
Copy Markdown
Contributor
|
It compiles again but I'm not able to test this atm. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Since I have no test sketch for the async parts, the only thing I could offer is to deploy it to some of my smart home devices and see if it behaves. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No automatic merge possible due to changes to the master in the meantime!