Export function instead of its returned value - #63
Closed
m-kusnierz wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Breaking change: export function instead of value returned from it to avoid caching the value
m-kusnierz
commented
Aug 16, 2023
Comment thread
package.json
| @@ -14,6 +14,7 @@ | |||
| }, | |||
| "dependencies": { | |||
| "moduleconfig": "^2.0.0", | |||
Copy link
Copy Markdown
Author
There was a problem hiding this comment.
This will be updated after releasing changes from ebdrup/moduleconfig#6
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
I'm closing this PR as we decided to implement these changes in forked repository for now. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This package doesn't work correctly together with Opentelemetry packages.
Changes:
Exported function in lib/nodeerrors.js instead of exporting value returned by the function to avoid caching the value (so the errors definitions)
It uses update moduleconfig that accepts a directory that should be checked for config, because it was also being cached by opentelemetry package (so it was always looking for the config in the same directory).
Used parent-module because of module.parent deprecation nodejs/node#32217
Depends on ebdrup/moduleconfig#6