FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: Add deployment repository by GliczDev · Pull Request #772 · eclipse-tm4e/tm4e · GitHub

feat: Add deployment repository - #772

Merged
sebthom merged 1 commit into
eclipse-tm4e:mainfrom
GliczDev:main
Jul 19, 2024
Merged

feat: Add deployment repository#772
sebthom merged 1 commit into
eclipse-tm4e:mainfrom
GliczDev:main

Conversation

Copy link
Copy Markdown
Contributor

What does this PR do?

Adds deployment repository


The only problem is that I'm not sure how should I configure Jenkinsfile for deployment
https://github.com/eclipse/tm4e/blob/d77316439d39a8254a455f207dbb4c582968a9e2/Jenkinsfile#L28
should I add deploy goal here?

sebthom commented Jul 19, 2024

Copy link
Copy Markdown
Member

Thanks for your PR. For being able to process this PR, you need to sign the Eclipse Contributor Agreement (ECA)

sebthom commented Jul 19, 2024

Copy link
Copy Markdown
Member

What does this PR do?

Adds deployment repository

The only problem is that I'm not sure how should I configure Jenkinsfile for deployment

https://github.com/eclipse/tm4e/blob/d77316439d39a8254a455f207dbb4c582968a9e2/Jenkinsfile#L28

should I add deploy goal here?

no, this job is only for snapshot builds.

Release builds are done by https://ci.eclipse.org/tm4e/job/promote-snapshot-to-release/ but I don't know what/how to change it so it deploys to maven central.

Copy link
Copy Markdown
Contributor Author

Thanks for your PR. For being able to process this PR, you need to sign the Eclipse Contributor Agreement (ECA)

done

deploys to maven central.

wdym maven central? my PR adds repo.eclipse.org tm4e deployment repository.

Release builds are done by https://ci.eclipse.org/tm4e/job/promote-snapshot-to-release/ but I don't know what/how to change it so it deploys to maven central.

I think adding mvn deploy should be enough, but I don't use maven so I'm not sure.

sebthom commented Jul 19, 2024

Copy link
Copy Markdown
Member

I think adding mvn deploy should be enough, but I don't use maven so I'm not sure.

adding deploy here will still only publish to the snapshot repo as this Jenkins job is not used to create releases.
also it would unnecessarily publish all modules to the snapshot repo, not only the core module.
I am going to prepare a separate PR that only publishes the core module.

sebthom merged commit 7d8690e into eclipse-tm4e:main Jul 19, 2024

sebthom commented Jul 19, 2024

Copy link
Copy Markdown
Member

Thanks for the PR!

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL